-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented email sending logic including forgot password, and email verification #187
Conversation
This is very cool. Awesome work, @taylorstine. I request that others to take a look at this and comment. It does not include a default emailSender? |
@gfosco No, I figured the documentation may have to be updated or something to show an example implementation. I can easily add one, but I just figured the implementation of A default implementation could use SES, it would just require some configuration in the AWS Cloud Console from the implementer. Also, unless parse is still open to hosting a [email protected] email, we would also need the email address from which to send the emails |
Because of our previous module support, I'd like to see the default be a Mailgun or Mandrill implementation, but I guess we could always add that later. |
Cool, I'll look in to that. I've never used those before so I'll have to do some investigation. |
This looks pretty sweet, odd timing too as I just submitted a pull request with support for a MailAdapter and Mailgun (#191), maybe we could bridge the two together? |
@jamiechapman that sounds good. @gfosco would you rather we implement this now, or would you prefer the default implementation in a separate PR? |
@taylorstine I'd like to accept @jamiechapman 's MailAdapter method. Are you okay with implementing SES through that? |
👍 great job |
Great work @taylorstine and @jamiechapman! |
@gfosco 👍 I'm not sure if this is what we're talking about doing, but I think the best thing to do might be to allow a user to specify a |
@taylorstine definitely! Maybe we could take some inspiration from the |
@jamiechapman I like that idea, where the user could specify options and based on those options we decide how to route the sending logic. The payload to send could be something like
And the user could specify a middleware type function to modify these parameters, with the default as a function that just returns this payload. |
Conflicts: index.js users.js
@taylorstine updated the pull request. |
Lets consolidate discussion in #275 |
Increasing code coverage, fix comments and define static type of the PaseSchema
Closing this, looks like the eventual solution will come from issue 275. |
This is an attempt to remove this todo
This will handle email password reset and email verifications.
Note that this adds views to parse-server, to provide a default implementation of the webpage that validates an email, or resets a password. A user can override this default implementation in their express app. (side note, notice the references on some image assets to
parse.com
. Not sure if this is ok or not).This adds a new optional configuration parameter
emailSender
, which is given all of the information needed to send one of the verification emails.Here's what my implementation looks like